Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Command Quality of Life #2179

Merged
merged 3 commits into from
Dec 15, 2024
Merged

Conversation

mehwaffle10
Copy link
Contributor

Quality of life improvements for the new command system. Allow syntax prior to the command rework. Tested on my balance mod since the command rework was added.

Status

  • READY: this PR is (to the best of your knowledge) ready to be incorporated into the game.

Description

Address some common issues when using commands. Makes the following changes:

  • Ignore character case when using commands
  • Allow ! instead of / when using commands
  • Default to the spawn command if no other command matches

Steps to Test or Reproduce

  1. Enable commands by setting sv_test to 1
  2. Type !Keg to spawn a keg

git branch used: https://github.com/mehwaffle10/kag-base/tree/command-qol

Ignore character case when using commands. Allow ! instead of / when using commands. Default to the spawn command if no other command matches
@mehwaffle10 mehwaffle10 changed the title Update ChatCommandManager.as Command Quality of Life Nov 23, 2024
spacing. gotta love 4x spaces
Vam-Jam
Vam-Jam previously approved these changes Nov 23, 2024
Copy link
Member

@Vam-Jam Vam-Jam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works, small request but for localhost servers, could you allow people to do !keg [count] to spawn multiple objects at once, e.g. !keg 20 will spawn 20 kegs

It's not needed for normal sandbox as it would be abused pretty heavily but for localhost, it would be extremely handy.

@Vam-Jam Vam-Jam added ready A pull request that functions correctly and is ready for testing Sandbox PR that is focused towards Sandbox labels Nov 23, 2024
@Vam-Jam Vam-Jam added this to the Next Patch milestone Nov 23, 2024
@mugg91
Copy link
Contributor

mugg91 commented Nov 23, 2024

I think it would be better to have acceptable prefixes ("/" and "!") in one place rather than setting "/" and checking for "!" later.

@asumagic asumagic merged commit 92e34d3 into transhumandesign:master Dec 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready A pull request that functions correctly and is ready for testing Sandbox PR that is focused towards Sandbox
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants