[fixed/changed] Ladders placed next to waterfalls won't decay #2187
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Description
Fixes #2096
WaterDecaysDoors.as
says that water should be checked for the tile above, left of and right of ladders and wooden doors.This PR changes that to check for water in the blob's tile position (center). This fixes that ladder placed inside in a 1 tile water puddle doesn't decay.
Also, above, left and right are only checked if shape consts
waterPasses
returns false, therefore allowing ladders to be placed to the left or right of waterfalls without decaying.(It's worth noting that wooden doors cannot be placed next to waterfalls without water spreading on top of it.
Please consider these suggestions for improving the water behavior #2077 - the 2nd example suggests that placing anything solid (including a wooden door) shouldn't spread water on top of it if it's a waterfall leading into the void.)
Instead of fetching shape and shape consts, you could also simply tag Ladder blobs and check for that tag, but I didn't want to add clutter with tags when the problem could be solved without using tags.