Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fixed/changed] Ladders placed next to waterfalls won't decay #2187

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mugg91
Copy link
Contributor

@mugg91 mugg91 commented Nov 25, 2024

Status

  • READY: this PR is (to the best of your knowledge) ready to be incorporated into the game.

Description

[fixed/changed] Ladder decays next to waterfalls even though it doesn't touch the water
[fixed] Ladder placed in a 1 tile water puddle didn't decay

Fixes #2096

WaterDecaysDoors.as says that water should be checked for the tile above, left of and right of ladders and wooden doors.

This PR changes that to check for water in the blob's tile position (center). This fixes that ladder placed inside in a 1 tile water puddle doesn't decay.
Also, above, left and right are only checked if shape consts waterPasses returns false, therefore allowing ladders to be placed to the left or right of waterfalls without decaying.

(It's worth noting that wooden doors cannot be placed next to waterfalls without water spreading on top of it.
Please consider these suggestions for improving the water behavior #2077 - the 2nd example suggests that placing anything solid (including a wooden door) shouldn't spread water on top of it if it's a waterfall leading into the void.)

Instead of fetching shape and shape consts, you could also simply tag Ladder blobs and check for that tag, but I didn't want to add clutter with tags when the problem could be solved without using tags.

@Vam-Jam Vam-Jam added change A change to an existing feature or mechanic fix Fixes a bug labels Nov 28, 2024
Copy link
Member

@Vam-Jam Vam-Jam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works from testing in localhost + dedi. Could not find any weirdness compared to vanilla, may need more testing.

@Vam-Jam Vam-Jam added testing needed An issue needs to undergo a testing sessions to verify the change or check for newly introduced bugs ready A pull request that functions correctly and is ready for testing labels Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
change A change to an existing feature or mechanic fix Fixes a bug ready A pull request that functions correctly and is ready for testing testing needed An issue needs to undergo a testing sessions to verify the change or check for newly introduced bugs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ladder takes water damage when not inside water
2 participants