Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fixed] Keg sparkle sound was not playing on rejoin #2298

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mugg91
Copy link
Contributor

@mugg91 mugg91 commented Jan 5, 2025

Status

  • READY: this PR is (to the best of your knowledge) ready to be incorporated into the game.

Description

Fixes #2296

This fixes that Keg was not making a sparkle sound when activated when rejoining the server.

Reproducing

Join server, light a Keg, leave and rejoin. Keg isn't making a sound. After this PR, it will make a sound.

For testing, I suggest that you increase the explosion timer in Keg.as
this.set_f32("keg_time", 180.0f); --> this.set_f32("keg_time", 1800.0f);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No keg sparkle sound on rejoin
1 participant