Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sender usage updates #2958

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

sender usage updates #2958

wants to merge 2 commits into from

Conversation

GbArc
Copy link
Collaborator

@GbArc GbArc commented Jan 30, 2025

No description provided.

Copy link
Collaborator

@murtaza-swati murtaza-swati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GbArc does this still requires the internal user record in DB to have login/name present? Because as I understand, the main issue would still persist. From Michal comment on the ticket it is stated as:

"the description is empty? We have this 'special ids' known, we can even have short config in travis-web on how to put user names on them (eg cron job / triggered by bot )"

@gbarc-dt
Copy link
Collaborator

gbarc-dt commented Feb 3, 2025

Yes, you need the login/name in the database, there are already such users so why making more and more workarounds

@murtaza-swati
Copy link
Collaborator

Yes, you need the login/name in the database, there are already such users so why making more and more workarounds

previously I remember this bot user had a login present but now it's not there. so that's why we need some defaults here.

@gbarc-dt
Copy link
Collaborator

gbarc-dt commented Feb 3, 2025

Yes, you need the login/name in the database, there are already such users so why making more and more workarounds

previously I remember this bot user had a login present but now it's not there. so that's why we need some defaults here.

ok, if defaults for something not in db are required, i'll put it into api config so web receives it properly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants