Generate test matrix from tested-with GHCs #308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@robrix yo! may I ask for a review? |
|
@BekaValentine hi! How can we get this PR moving forward? |
robrix
approved these changes
Apr 12, 2024
Comment on lines
+20
to
+25
| - name: Extract the tested GHC versions | ||
| id: set-matrix | ||
| run: | | ||
| wget https://github.com/Kleidukos/get-tested/releases/download/v0.1.5.0/get-tested-0.1.5.0-linux-amd64 -O get-tested | ||
| chmod +x get-tested | ||
| ./get-tested --ubuntu tree-sitter/tree-sitter.cabal >> $GITHUB_OUTPUT |
There was a problem hiding this comment.
Actually in the meantime it gained a GitHub Action. I'll send a follow-up PR. :)
Comment on lines
+42
to
+45
| -Wno-star-is-type | ||
| -Wno-missing-deriving-strategies | ||
| -Wno-missing-safe-haskell-mode | ||
| -Wno-prepositive-qualified-module |
There was a problem hiding this comment.
Good call dropping the conditionals.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the CI setup a bit:
The
tested-withstanza of the cabal file is updated to reflect a canonical list of GHC versions that are being actively tested.This list is used to generate a CI matrix.
Supported
baseversion is set to 4.14 / GHC 8.10.7, which makes some conditionals likeif (impl(ghc >= 8.6))redundant.A dependabot config has been setup to offer PR to update the github actions used.