fix: don't call free() on Windows

This may lead to some memory leaks, but at least it won't crash.
tree-sitter · Dec 8, 2024 · 9c5eb24 · 9c5eb24
1 parent 7369f7f
commit 9c5eb24
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 3 deletions.
diff --git a/src/main/java/io/github/treesitter/jtreesitter/Node.java b/src/main/java/io/github/treesitter/jtreesitter/Node.java
@@ -23,6 +23,9 @@ public final class Node {
     private final Arena arena = Arena.ofAuto();
     private boolean wasEdited = false;
 
+    // FIXME: figure out why free() crashes on Windows
+    private static final boolean IS_UNIX = !System.getProperty("os.name").startsWith("Windows");
+
     Node(MemorySegment self, Tree tree) {
         this.self = self;
         this.tree = tree;
@@ -437,7 +440,7 @@ public TreeCursor walk() {
     public String toSexp() {
         var string = ts_node_string(self);
         var result = string.getString(0);
-        free(string);
+        if (IS_UNIX) free(string);
         return result;
     }
 

diff --git a/src/main/java/io/github/treesitter/jtreesitter/Tree.java b/src/main/java/io/github/treesitter/jtreesitter/Tree.java
@@ -22,6 +22,9 @@ public final class Tree implements AutoCloseable, Cloneable {
     private final Language language;
     private @Nullable List<Range> includedRanges;
 
+    // FIXME: figure out why free() crashes on Windows
+    private static final boolean IS_UNIX = !System.getProperty("os.name").startsWith("Windows");
+
     Tree(MemorySegment self, Language language, @Nullable String source, @Nullable Charset charset) {
         arena = Arena.ofShared();
         this.self = self.reinterpret(arena, TreeSitter::ts_tree_delete);
@@ -92,7 +95,7 @@ public List<Range> getIncludedRanges() {
                     var range = TSRange.asSlice(ranges, i);
                     includedRanges.add(Range.from(range));
                 }
-                free(ranges);
+                if (IS_UNIX) free(ranges);
             }
         }
         return Collections.unmodifiableList(includedRanges);
@@ -119,7 +122,7 @@ public List<Range> getChangedRanges(Tree newTree) {
                 var range = TSRange.asSlice(ranges, i);
                 changedRanges.add(Range.from(range));
             }
-            free(ranges);
+            if (IS_UNIX) free(ranges);
             return changedRanges;
         }
     }