Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Catalog: use config interface #8569

Merged
merged 1 commit into from
Jan 30, 2025
Merged

Catalog: use config interface #8569

merged 1 commit into from
Jan 30, 2025

Conversation

N-o-Z
Copy link
Member

@N-o-Z N-o-Z commented Jan 29, 2025

Closes #8568

Change Description

Catalog should keep the config interface instead of the BaseConfig struct.
Open issues that are out of scope and will be handled in different PRs:

  1. Remove walker factory and use BlockAdapter.GetWalker instead (based on repository)
  2. Remove signing key and retrieve it dynamically from block adapter (based on repository)

@N-o-Z N-o-Z added exclude-changelog PR description should not be included in next release changelog msb labels Jan 29, 2025
@N-o-Z N-o-Z requested a review from a team January 29, 2025 22:29
@N-o-Z N-o-Z self-assigned this Jan 29, 2025
@github-actions GitHub Actions
Copy link

E2E Test Results - DynamoDB Local - Local Block Adapter

13 passed

@github-actions GitHub Actions
Copy link

E2E Test Results - Quickstart

11 passed

itaigilo
itaigilo approved these changes Jan 30, 2025
View reviewed changes
Copy link
Contributor

@itaigilo itaigilo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice and clean 👍

@N-o-Z N-o-Z merged commit 8ec58b3 into master Jan 30, 2025
42 checks passed
@N-o-Z N-o-Z deleted the task/modify-catalog-config-8568 branch January 30, 2025 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@itaigilo itaigilo itaigilo approved these changes

Assignees

@N-o-Z N-o-Z

Labels
exclude-changelog PR description should not be included in next release changelog msb
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Catalog config should use config interface and not BaseConfig
2 participants
@N-o-Z @itaigilo