-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Plugin Development Kit: Connectors #1287
Closed
marioortizmanero
wants to merge
26
commits into
tremor-rs:connectors
from
marioortizmanero:pdk-propagate
Closed
Plugin Development Kit: Connectors #1287
marioortizmanero
wants to merge
26
commits into
tremor-rs:connectors
from
marioortizmanero:pdk-propagate
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is very WIP yet so I do not suggest reviewing the code at this moment. I will let the team know once it's at least working. |
Closing in favor of marioortizmanero#1 (which I'm not sure how to make over this repo instead of over my fork) |
6 tasks
This was referenced Nov 20, 2021
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request
Description
This Pull Request is my first approach to integrating the new Plugin Development Kit (#791) for the connectors artifact. It requires a ton of changes because it moves every single connector into a separate crate, and rewrites part of the internals so that they can be used safely through the FFI boundary.
Related
Checklist
Custom checklist:
simd_json::Value
inOpMeta
StableAbi
derive invalue_trait
Performance
I do have a few benchmarks so far in https://github.com/marioortizmanero/pdk-experiments, which I will analyze in a new post on nullderef.com. These do not represent a real usage of Tremor, however, so I will make a few more once everything is working properly.