Skip to content

Commit

Permalink
Rename TRENTO_DOMAIN to TRENTO_WEB_ORIGIN (#2682)
Browse files Browse the repository at this point in the history
* Rename TRENTO_DOMAIN to TRENTO_WEB_ORIGIN

* adjust helm value
  • Loading branch information
nelsonkopliku authored Jun 10, 2024
1 parent 4e016fb commit 94795c2
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 5 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -752,7 +752,7 @@ jobs:
)
env:
IMAGE_REPOSITORY: ghcr.io/${{ github.repository_owner }}
TRENTO_DOMAIN: ${{ secrets.TRENTO_DEMO_IP }}
TRENTO_WEB_ORIGIN: ${{ secrets.TRENTO_DEMO_IP }}
TRENTO_NAMESPACE: ${{ secrets.TRENTO_NAMESPACE }}
TRENTO_ADMIN_EMAIL: ${{ secrets.TRENTO_ADMIN_EMAIL }}
TRENTO_INGRESS_CLASS: ${{ secrets.TRENTO_INGRESS_CLASS }}
Expand Down Expand Up @@ -799,7 +799,7 @@ jobs:
--set trento-wanda.image.pullPolicy=Always \
--set trento-wanda.image.repository="${IMAGE_REPOSITORY}/trento-wanda" \
--set trento-wanda.image.tag="demo" \
--set trento-web.trentoDomain="${TRENTO_DOMAIN}" \
--set trento-web.trentoWebOrigin="${TRENTO_WEB_ORIGIN}" \
-f ../../hack/cert-manager/override-values.yaml
run-photofinish-demo-env:
Expand Down
4 changes: 2 additions & 2 deletions config/runtime.exs
Original file line number Diff line number Diff line change
Expand Up @@ -58,9 +58,9 @@ if config_env() in [:prod, :demo] do
""")

trento_origin =
System.get_env("TRENTO_DOMAIN") ||
System.get_env("TRENTO_WEB_ORIGIN") ||
raise """
environment variable TRENTO_DOMAIN is missing.
environment variable TRENTO_WEB_ORIGIN is missing.
For example: yourdomain.example.com
"""

Expand Down
2 changes: 1 addition & 1 deletion guides/development/environment_variables.md
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ Dig into [./config](https://github.com/trento-project/web/blob/main/config/) dir

**Server**
- `PORT`
- `TRENTO_DOMAIN`
- `TRENTO_WEB_ORIGIN`

**Runner integration**
- `RUNNER_URL`
Expand Down

0 comments on commit 94795c2

Please sign in to comment.