Add checks execution domain logic #256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabriziosestito
force-pushed
the
add_runner_callbacks_endpoint
branch
2 times, most recently
from
3d7fcbc to
59eb80e
Compare
fabriziosestito
requested review from
dottorblaster,
arbulu89,
nelsonkopliku,
rtorrero and
stefanotorresi
fabriziosestito
changed the title
fabriziosestito
commented
Mar 29, 2022
| ) | ||
|
|
||
| # TODO: post event to callback |
arbulu89
reviewed
Mar 29, 2022
There was a problem hiding this comment.
Amazing, amazing job @fabriziosestito
I have noted down some discussion points, but the change looks super promising.
PD: This looks a crutial part of the project, and I think a mob review would be ideal
| "http://localhost:4000/api/runner/callback", | ||
| Jason.encode!(%{ | ||
| "event" => "execution_started", | ||
| "cluster_id" => cluster_id, |
There was a problem hiding this comment.
We need to implement this in the runner part. I have already forgotten hehe
nelsonkopliku
approved these changes
Mar 29, 2022
dottorblaster
approved these changes
Mar 29, 2022
lib/trento/application/integration/checks/dto/execution_completed_event.ex
Show resolved
Hide resolved
arbulu89
reviewed
Mar 30, 2022
| @@ -17,9 +15,8 @@ defmodule Trento.CheckResultReadModel do | |||
| field :cluster_id, Ecto.UUID, primary_key: true | |||
| field :host_id, Ecto.UUID, primary_key: true | |||
| field :check_id, :string, primary_key: true | |||
| field :result, Ecto.Enum, values: [:passing, :warning, :critical, :running] | |||
| field :result, Ecto.Enum, values: [:passing, :warning, :critical, :unknown] | |||
There was a problem hiding this comment.
Other small comment. From the runner, we pass the skipped result as well to show which were the skipped checks.
There was a problem hiding this comment.
noted, will come in follow up PRs
fabriziosestito
force-pushed
the
add_runner_callbacks_endpoint
branch
from
59eb80e to
6beed13
Compare
fabriziosestito
force-pushed
the
add_runner_callbacks_endpoint
branch
2 times, most recently
from
5665e29 to
f2ba0b1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is the first iteration of the runner checks execution.
It adds the domain logic in the cluster aggregate and the commands and events needed to perform an execution process.
It also temporarily fixes the old FE so we can have some user feedback (review, yay).
ATM we are leveraging the
MockRunnerin the development environment and ignoring the host connection settings.More to come!