-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add OperationForbiddenModal #3331
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we are going to review the banner text later on, then - code apart - this looks good to me.
Yes, the text that comes after the banner will depend on the operation itself. |
No need to discuss it here but wondering if we are going to have a warning message tailored to the specific SAP workload(s) in the host or it's going to be a generic message trying to cover all possible cases. For example:
|
@abravosuse I'm putting this PR back in draft. We clarified offline that we are going to do some adjustments to get the exact reasons of why the operation is forbidden to generate the modal message |
Perfect, @arbulu89 . Thank you! |
@abravosuse I have adjusted the component to accept a list of errors that we will send from the backend. This way we have a exact picture of why the operation was forbidden, so the user is aware of the reason.
All the texts are coming from the backend, who knows the exact reasons. |
Description
Add operation forbidden modal. We can render any kind of markdown and have specific description messages for each operation. For example:
PD: Don't check too much the text after the banner. We will review that in other PRs, when it is really implemented. This was just an example
How was this tested?
UT