Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve sap instance parsing to use the hostname to get the fields #475

Merged
merged 1 commit into from
Apr 29, 2022

Conversation

arbulu89
Copy link
Contributor

Improve the sap instance parsing to use the hostname as another filtering value. This way, we don't only use the instance number to find the correct instance.

We can get the instance hostname from sapcontrol properties:

{
  "value": "sapnwdpas",
  "property": "SAPLOCALHOST",
  "propertytype": "Attribute"
},

This fixes strange deployments like this one, where we have 2 instances with the same instance number:
image

New issue saying to create a E2E test scenario with this data:
#474

@arbulu89 arbulu89 added the bug Something isn't working label Apr 29, 2022
@arbulu89 arbulu89 force-pushed the improve-sap-app-parsing branch from cdb18c4 to b24967d Compare April 29, 2022 08:16
@arbulu89 arbulu89 merged commit 3ea6603 into main Apr 29, 2022
@arbulu89 arbulu89 deleted the improve-sap-app-parsing branch April 29, 2022 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Development

Successfully merging this pull request may close these issues.

3 participants