Improve sap instance parsing to use the hostname to get the fields #475
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve the sap instance parsing to use the hostname as another filtering value. This way, we don't only use the instance number to find the correct instance.
We can get the instance hostname from sapcontrol properties:
This fixes strange deployments like this one, where we have 2 instances with the same instance number:
New issue saying to create a E2E test scenario with this data:
#474