This repository has been archived by the owner on Sep 20, 2023. It is now read-only.
Towards winning the game #723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## develop #723 +/- ##
===========================================
- Coverage 86.86% 86.79% -0.08%
===========================================
Files 37 37
Lines 1652 1643 -9
Branches 126 125 -1
===========================================
- Hits 1435 1426 -9
Misses 217 217
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
richelbilderbeek
approved these changes
Feb 14, 2023
| } | ||
|
|
||
| // A game is over when the time limit is reached | ||
| // (682) A game is over when the time limit is reached |
There was a problem hiding this comment.
Beautiful simplification!
| @@ -1234,6 +1224,45 @@ void test_game() //!OCLINT tests may be many | |||
| assert(players == v_player); | |||
| } | |||
|
|
|||
| #ifdef FIX_ISSUE_721 | |||
| // (721) The largest player wins the game | |||
There was a problem hiding this comment.
Elegant win condition!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bunch of tests to make progress on Milestone 5: