Blender LDraw Render - refactor render dialog #416

trevorsandy · Jun 4, 2023 · 3583a53 · 3583a53
1 parent 95ffd2b
commit 3583a53
Show file tree

Hide file tree

Showing 14 changed files with 26 additions and 29 deletions.
diff --git a/builds/linux/obs/PKGBUILD b/builds/linux/obs/PKGBUILD
@@ -2,7 +2,7 @@
 #  Last Update: July 19, 2020
 #  Copyright (C) 2017 - 2023 by Trevor SANDY
 pkgname=lpub3d
-pkgver=2.4.6.3409
+pkgver=2.4.6.3410
 pkgrel=1
 pkgdesc="An LDraw Building Instruction Editor"
 url="https://github.com/trevorsandy/lpub3d.git"

diff --git a/builds/linux/obs/alldeps/PKGBUILD b/builds/linux/obs/alldeps/PKGBUILD
@@ -2,7 +2,7 @@
 #  Last Update: July 19, 2020
 #  Copyright (C) 2017 - 2023 by Trevor SANDY
 pkgname=lpub3d
-pkgver=2.4.6.3409
+pkgver=2.4.6.3410
 pkgrel=1
 pkgdesc="An LDraw Building Instruction Editor"
 url="https://github.com/trevorsandy/lpub3d.git"

diff --git a/builds/linux/obs/alldeps/debian/changelog b/builds/linux/obs/alldeps/debian/changelog
@@ -1,5 +1,5 @@
-lpub3d (2.4.6.3409) debian; urgency=medium
+lpub3d (2.4.6.3410) debian; urgency=medium
 
-  * LPub3D version 2.4.6.298.3409_20230604 for Linux
+  * LPub3D version 2.4.6.299.3410_20230604 for Linux
 
- -- Trevor SANDY <[email protected]>  Sun, 04 Jun 2023 02:34:05 +0200
+ -- Trevor SANDY <[email protected]>  Sun, 04 Jun 2023 02:36:01 +0200
diff --git a/builds/linux/obs/alldeps/debian/lpub3d.dsc b/builds/linux/obs/alldeps/debian/lpub3d.dsc
@@ -2,7 +2,7 @@ Format: 1.0
 Source: lpub3d
 Binary: lpub3d
 Architecture: any
-Version: 2.4.6.3409
+Version: 2.4.6.3410
 Maintainer: Trevor SANDY <[email protected]>
 Homepage: https://trevorsandy.github.io/lpub3d/
 Standards-Version: 3.9.7

diff --git a/builds/linux/obs/alldeps/lpub3d.spec b/builds/linux/obs/alldeps/lpub3d.spec
@@ -120,7 +120,7 @@ BuildRequires: fdupes
 Summary: An LDraw Building Instruction Editor
 Name: lpub3d
 Icon: lpub3d.xpm
-Version: 2.4.6.3409
+Version: 2.4.6.3410
 Release: <B_CNT>%{?dist}
 URL: https://trevorsandy.github.io/lpub3d
 Vendor: Trevor SANDY
@@ -797,7 +797,7 @@ update-desktop-database || true
 %endif
 
 %changelog
-* Sun Jun 04 2023 - trevor.dot.sandy.at.gmail.dot.com 2.4.6.3409
+* Sun Jun 04 2023 - trevor.dot.sandy.at.gmail.dot.com 2.4.6.3410
 - LPub3D 2.4.4 enhancements and fixes - see RELEASE_NOTES for details
 
 * Tue May 31 2022 - trevor dot sandy at gmail dot com 2.4.4.2670

diff --git a/builds/linux/obs/debian/changelog b/builds/linux/obs/debian/changelog
@@ -1,5 +1,5 @@
-lpub3d (2.4.6.3409) debian; urgency=medium
+lpub3d (2.4.6.3410) debian; urgency=medium
 
-  * LPub3D version 2.4.6.298.3409_20230604 for Linux
+  * LPub3D version 2.4.6.299.3410_20230604 for Linux
 
- -- Trevor SANDY <[email protected]>  Sun, 04 Jun 2023 02:34:06 +0200
+ -- Trevor SANDY <[email protected]>  Sun, 04 Jun 2023 02:36:02 +0200
diff --git a/builds/linux/obs/debian/lpub3d.dsc b/builds/linux/obs/debian/lpub3d.dsc
@@ -2,7 +2,7 @@ Format: 1.0
 Source: lpub3d
 Binary: lpub3d
 Architecture: any
-Version: 2.4.6.3409
+Version: 2.4.6.3410
 Maintainer: Trevor SANDY <[email protected]>
 Homepage: https://trevorsandy.github.io/lpub3d/
 Standards-Version: 3.9.7

diff --git a/builds/linux/obs/lpub3d.spec b/builds/linux/obs/lpub3d.spec
@@ -82,7 +82,7 @@ BuildRequires: fdupes
 Summary: An LDraw Building Instruction Editor
 Name: lpub3d
 Icon: lpub3d.xpm
-Version: 2.4.6.3409
+Version: 2.4.6.3410
 Release: 1%{?dist}
 URL: https://trevorsandy.github.io/lpub3d
 Vendor: Trevor SANDY
@@ -313,7 +313,7 @@ update-desktop-database || true
 %endif
 
 %changelog
-* Sun Jun 04 2023 - trevor.dot.sandy.at.gmail.dot.com 2.4.6.3409
+* Sun Jun 04 2023 - trevor.dot.sandy.at.gmail.dot.com 2.4.6.3410
 - LPub3D 2.4.4 enhancements and fixes - see RELEASE_NOTES for details
 
 * Tue May 31 2022 - trevor dot sandy at gmail dot com 2.4.4.2670

diff --git a/builds/utilities/version.info b/builds/utilities/version.info
@@ -1 +1 @@
-2 4 6 298 3409 9cfc1e71c
+2 4 6 299 3410 95ffd2b1d
diff --git a/gitversion.pri b/gitversion.pri
@@ -41,7 +41,7 @@ equals(GIT_DIR, undefined) {
 
     # Check if we do not have a valid version number (i.e. no version tag found)
     isEmpty(GIT_VERSION) {
-        GIT_REVISION = 298
+        GIT_REVISION = 299
         GIT_SHA      = $$system($$GIT_BASE_COMMAND rev-parse --short HEAD 2> $$NULL_DEVICE)
         GIT_COMMIT   = $$system($$GIT_BASE_COMMAND rev-list --count HEAD 2> $$NULL_DEVICE)
         GIT_VERSION  = v$${VERSION}-$${GIT_REVISION}-$${GIT_SHA}
@@ -69,7 +69,7 @@ equals(GIT_DIR, undefined) {
         # Get commit count
         GIT_COMMIT = $$system($$GIT_BASE_COMMAND rev-list --count HEAD 2> $$NULL_DEVICE)
         isEmpty(GIT_COMMIT) {
-            GIT_COMMIT = 3409
+            GIT_COMMIT = 3410
             message("~~~ ERROR! GIT_COMMIT NOT DEFINED, USING $$GIT_COMMIT ~~~")
         }
 
@@ -117,7 +117,7 @@ if (equals(USE_GIT_VER_FILE, true)|equals(USE_VERSION_INFO_VAR, true)) {
             GIT_VERSION = $$cat($$GIT_VER_FILE, lines)
         } else {
             message("~~~ ERROR! $$GIT_DIR_ENV VERSION_INFO FILE $$GIT_VER_FILE NOT FOUND ~~~")
-            GIT_VERSION = $${VERSION}.298.3409.9cfc1e71c
+            GIT_VERSION = $${VERSION}.299.3410.95ffd2b1d
             message("~~~ GIT_DIR [$$GIT_DIR_ENV, USING VERSION] $$GIT_VERSION ~~~")
             GIT_VERSION ~= s/\./" "
         }

diff --git a/mainApp/docs/README.txt b/mainApp/docs/README.txt
@@ -1,4 +1,4 @@
-LPub3D 2.4.6.298.3409 (04 06 2023 02:34:06)
+LPub3D 2.4.6.299.3410 (04 06 2023 02:36:02)
 
 Features, enhancements, fixes and changes
 ------------

diff --git a/mainApp/docs/RELEASE_NOTES.html b/mainApp/docs/RELEASE_NOTES.html
@@ -18,7 +18,7 @@
 <table class="tg">
   <tr>
     <th class="tg-0pky">
-      <h4><a id="LPub3D_0"></a>LPub3D 2.4.6.298.3409 (04 06 2023 02:34:06)</h4>
+      <h4><a id="LPub3D_0"></a>LPub3D 2.4.6.299.3410 (04 06 2023 02:36:02)</h4>
         <hr>
           <p>
              <span class="tg-1pky">LPub3D Official release.</span><br>

diff --git a/mainApp/extras/LPub3D_Npp_UDL.xml b/mainApp/extras/LPub3D_Npp_UDL.xml
@@ -14,8 +14,8 @@
 ;;
 ;; Author......: Trevor SANDY
 ;; Name........: LPub3D_Npp_UDL.xml
-;; Version.....: 2.4.6.298.3409
-;; Last Update.: Sun, 04 Jun 2023 02:34:06 +0200
+;; Version.....: 2.4.6.299.3410
+;; Last Update.: Sun, 04 Jun 2023 02:36:02 +0200
 ;; License.....: GPLv3
 ;; Homepage....: https://trevorsandy.github.io/lpub3d
 ;; Copyright (C) 2021 - 2023 by Trevor SANDY

diff --git a/mainApp/renderdialog.cpp b/mainApp/renderdialog.cpp
@@ -245,23 +245,20 @@ void RenderDialog::on_RenderSettingsButton_clicked()
 
         double renderPercentage = mCsiKeyList.at(K_MODELSCALE).toDouble();
 
-        bool blenderConfigured = !Preferences::blenderImportModule.isEmpty();
-
         bool ok = BlenderPreferencesDialog::getBlenderPreferences(
                     mWidth,
                     mHeight,
                     renderPercentage,
                     false /*document model*/,
                     this);
 
-        if (ok) {
+        if (ok)
             mCsiKeyList[K_MODELSCALE] = QString::number(renderPercentage);
-            blenderConfigured = !Preferences::blenderImportModule.isEmpty();
-        }
 
-        ui->RenderButton->setEnabled(blenderConfigured);
-        if (!blenderConfigured)
+        if (Preferences::blenderImportModule.isEmpty())
             ui->RenderButton->setToolTip(tr("Blender not configured. Click 'Settings' to configure."));
+        else
+            ui->RenderButton->setEnabled(true);
     }
 }