fix: Fix support for relative base path when DioOptions exist (#704)

trevorwang · Sep 2, 2024 · 06e30c3 · 06e30c3
1 parent c13890c
commit 06e30c3
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 4 deletions.
diff --git a/generator/lib/src/generator.dart b/generator/lib/src/generator.dart
@@ -1316,9 +1316,10 @@ You should create a new class to encapsulate the response.
             Map.from(extraOptions)
               ..[_queryParamsVar] = namedArguments[_queryParamsVar]!
               ..[_path] = namedArguments[_path]!
-              ..[_baseUrlVar] = extraOptions.remove(_baseUrlVar)!.ifNullThen(
-                    refer(_dioVar).property('options').property('baseUrl'),
-                  ),
+              ..[_baseUrlVar] = refer('_combineBaseUrls').call([
+                refer(_dioVar).property('options').property('baseUrl'),
+                extraOptions.remove(_baseUrlVar)!,
+              ]),
           )
           .cascade('data')
           .assign(namedArguments[_dataVar]!);

diff --git a/generator/test/src/generator_test_src.dart b/generator/test/src/generator_test_src.dart
@@ -1276,7 +1276,10 @@ abstract class TestModelList {
     newOptions.headers.addAll(_headers);
     final _options = newOptions.copyWith(
       method: 'GET',
-      baseUrl: baseUrl ?? _dio.options.baseUrl,
+      baseUrl: _combineBaseUrls(
+        _dio.options.baseUrl,
+        baseUrl,
+      ),
       queryParameters: queryParameters,
       path: '',
     )..data = _data;