Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add support @Extras() #648

Merged
merged 3 commits into from
Feb 3, 2024
Merged

Conversation

XuanTung95
Copy link
Contributor

@XuanTung95 XuanTung95 commented Dec 31, 2023

Add @Extras() to pass extra options to dio interceptors for each request as parameters.
The code is mostly copy-pasted from the @queries implementation.
Fix #445

Usage is the same as @queries

   @GET("/get")
   Future<String> foo(@Extras() Map<String, dynamic> extras)

@trevorwang
Copy link
Owner

�Please fix the test issue

@XuanTung95 XuanTung95 changed the title fear: Add support @Extras() feat: Add support @Extras() Jan 18, 2024
@XuanTung95
Copy link
Contributor Author

Hi @trevorwang

I updated both retrofit and retrofit_generator.
The tests are failed because it could not find retrofit: ^4.1.0 which is not published yet.
I changed to retrofit: path: ../retrofit in retrofit_generator so it can run the test.

@trevorwang trevorwang merged commit a785dfb into trevorwang:master Feb 3, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Really need to pass custom Extra field to Dio for each request
2 participants