Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deprecations of withNullability #703

Merged
merged 5 commits into from
Sep 2, 2024
Merged

Fix deprecations of withNullability #703

merged 5 commits into from
Sep 2, 2024

Conversation

Carapacik
Copy link
Contributor

In analyzer 6.5.0 they remove support for getDisplayString(withNullability: false):
String getDisplayString Only non-nullable by default mode is supported.

Analyzer 6.5.0 and higher support Dart ^3.3 and I also update sdk and replace tuple with records

@Carapacik
Copy link
Contributor Author

@trevorwang plz check it

@trevorwang
Copy link
Owner

@Carapacik Thanks for the contribution.
Most of things look fine.
Let's move the retrofit to 5.0 and generator to 9.0 due to the breaking change of dart dependency

@Carapacik
Copy link
Contributor Author

Carapacik commented Sep 2, 2024

@trevorwang I think there is no point in raising the retrofit version, since it will work with the new version of the generator. But the generator can be raised

@trevorwang
Copy link
Owner

@Carapacik Yes. You are right. Let's only raise the generator

@Carapacik
Copy link
Contributor Author

Carapacik commented Sep 2, 2024

@trevorwang I am ready for merge. Updated version in retrofit for updated README

@trevorwang trevorwang merged commit 8a0d0b5 into trevorwang:master Sep 2, 2024
1 of 2 checks passed
@trevorwang
Copy link
Owner

Have been published to pub . Thanks the update again!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants