Various changes from Chromium, redux, part 1. #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From Chromium.
From Chromium.
Adapted from a Chromium patch, with tests and client-side portions added.
SSL 3.0 requires minimal padding. (TLS doesn't require it but accepts it, so apply uniformly to both.) From Chromium.
davidben
force-pushed
the
chromium-patches-1
branch
from
a1f1dfb to
daf2e15
Compare
trevp
added a commit
that referenced
this pull request
Mar 24, 2015
Various changes from Chromium, redux, part 1.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the interest of not sitting on all of these until I find time to clean them up, here's the first half of #50. They're unchanged from the original PR except that FALLBACK_SCSV has been cleaned up. It now implements the client half as well and uses it to implement a pair of tests. I removed the configuration option for the server half; I figure that's more of a "patch in a bug" sort of change that we ought to keep carrying in our own tree. (Though if you want it, I'm happy to stop carrying them!)