Merge branch 'release/1.3.2'

trexima · Nov 4, 2024 · 6115e7a · 6115e7a
2 parents 3435240 + 731d68b
commit 6115e7a
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 6 deletions.
diff --git a/composer.json b/composer.json
@@ -1,7 +1,7 @@
 {
     "name": "trexima/harvey-client",
     "description": "Client for Harvey API v2",
-    "version": "1.3.1",
+    "version": "1.3.2",
     "type": "library",
     "license": "MIT",
     "authors": [

diff --git a/src/Client.php b/src/Client.php
@@ -179,12 +179,17 @@ public function searchIsco(?string $title = null, ?int $workArea = null, ?string
         if ($perPage === 0) {
             $args['pagination'] = false;
         }
-        $cacheKey = 'search-isco-' . crc32(json_encode($args));
-        $result = $this->cache->get($cacheKey, function (ItemInterface $item) use ($args) {
-            $item->expiresAfter($this->cacheTtl);
+        if ($json = json_encode($args)) {
+            $cacheKey = 'search-isco-' . crc32($json);
+            $result = $this->cache->get($cacheKey, function (ItemInterface $item) use ($args) {
+                $item->expiresAfter($this->cacheTtl);
+                $resource = $this->get('api/isco', $args);
+                return (string)$resource->getBody();
+            });
+        } else {
             $resource = $this->get('api/isco', $args);
-            return (string)$resource->getBody();
-        });
+            $result = (string)$resource->getBody();
+        }
         return $this->jsonDecode($result);
     }