mobile tabs fix after code review

trexima · Oct 20, 2021 · 53e1735 · 53e1735
1 parent 8ea97f2
commit 53e1735
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 457 deletions.
diff --git a/src/idsk/components/tabs/_tabs.scss b/src/idsk/components/tabs/_tabs.scss
@@ -93,8 +93,8 @@
       padding: govuk-spacing(4);
       margin: 0;
       background-color: govuk-colour("grey-4");
-      box-shadow: 0px 0px 2px rgba(0, 0, 0, 0.25);
-      border-radius: 2px 2px 0px 0px;
+      box-shadow: 0 0 2px rgba(0, 0, 0, .25);
+      border-radius: 2px 2px 0 0;
 
       &:focus,
       &:active {
@@ -117,8 +117,8 @@
     @include mq($until: tablet) {
       padding: govuk-spacing(4);
       overflow: auto;
-      box-shadow: 0px 0px 2px rgba(0, 0, 0, 0.25);
-      border-radius: 2px 2px 0px 0px;
+      box-shadow: 0 0 2px rgba(0, 0, 0, .25);
+      border-radius: 2px 2px 0 0;
 
       &--hidden {
         display: none;

diff --git a/src/idsk/components/tabs/tabs.test.js b/src/idsk/components/tabs/tabs.test.js
diff --git a/src/idsk/components/tabs/template.njk b/src/idsk/components/tabs/template.njk
@@ -12,7 +12,7 @@
       {% if item %}
         {% set id = item.id if item.id else idPrefix + "-" + loop.index %}
         <li class="idsk-tabs__list-item{% if loop.index == 1 %} idsk-tabs__list-item--selected{% endif %}">
-          <a class="idsk-tabs__tab" href="#{{ id }}"
+          <a class="idsk-tabs__tab" href="#{{ id }}" title="{{ item.label }}"
             {%- for attribute, value in item.attributes %} {{attribute}}="{{value}}"{% endfor %} item="{{ loop.index0 }}">
             {{ item.label }}
           </a>