Merge pull request alphagov#1276 from alphagov/fix-ie8-banner

Fix review app banner for IE8
trexima · Apr 17, 2019 · ae3b267 · ae3b267
2 parents ba5fc63 + 90bd34f
commit ae3b267
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 12 deletions.
diff --git a/app/assets/scss/app-ie8.scss b/app/assets/scss/app-ie8.scss
@@ -1,2 +1,3 @@
 @import "../../../src/all-ie8";
 @import "partials/app";
+@import "partials/banner";
diff --git a/app/assets/scss/partials/_banner.scss b/app/assets/scss/partials/_banner.scss
@@ -1,10 +1,9 @@
 .app-banner {
-  font-family: sans-serif;
-  font-size: 2rem;
-  line-height: 1.5;
-  overflow: hidden;
-  padding-bottom: govuk-spacing(6);
   padding-top: govuk-spacing(6);
+  padding-bottom: govuk-spacing(6);
+  overflow: hidden;
+  @include govuk-font($size: 36, $line-height: 1.5)
+  font-family: sans-serif;
 
   .app-banner__button {
     margin-bottom: 0;
@@ -15,22 +14,26 @@
     font-size: inherit;
   }
 
-  .govuk-link:not(:focus) {
-    color: inherit;
+  .govuk-link {
+    color: govuk-colour("white");
+  }
+
+  .govuk-link:focus {
+    color: $govuk-text-colour;
   }
 }
 
 .app-banner--warning {
-  background: govuk-colour('red');
-  color: govuk-colour('white');
+  color: govuk-colour("white");
+  background: govuk-colour("red");
 
   .app-banner__button,
   .app-banner__button:active,
   .app-banner__button:hover,
   .app-banner__button:focus {
-    background: govuk-colour('white');
-    box-shadow: 0 2px 0 $govuk-text-colour;
-    color: $govuk-text-colour;
     margin-bottom: 0;
+    color: $govuk-text-colour;
+    background: govuk-colour("white");
+    box-shadow: 0 2px 0 $govuk-text-colour;
   }
 }