Fix deprecations due to jest

1. Remove accidental async in describe() 2. Config key renamed to `setupFilesAfterEnv`
trexima · Apr 17, 2019 · eadafef · eadafef
1 parent 85383dd
commit eadafef
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 4 deletions.
diff --git a/package.json b/package.json
@@ -93,7 +93,9 @@
     ]
   },
   "jest": {
-    "setupTestFrameworkScriptFile": "./config/jest-setup.js",
+    "setupFilesAfterEnv": [
+      "./config/jest-setup.js"
+    ],
     "snapshotSerializers": [
       "jest-serializer-html"
     ],

diff --git a/src/all.test.js b/src/all.test.js
@@ -39,7 +39,7 @@ afterAll(async (done) => {
 })
 
 describe('GOV.UK Frontend', () => {
-  describe('javascript', async () => {
+  describe('javascript', () => {
     it('can be accessed via `GOVUKFrontend`', async () => {
       await page.goto(baseUrl + '/', { waitUntil: 'load' })
 
@@ -113,7 +113,7 @@ describe('GOV.UK Frontend', () => {
       await page.waitForSelector('#conditional-scoped-1', { hidden: false })
     })
   })
-  describe('global styles', async () => {
+  describe('global styles', () => {
     it('are disabled by default', async () => {
       const sass = `
         @import "all";

diff --git a/src/components/error-summary/error-summary.test.js b/src/components/error-summary/error-summary.test.js
@@ -43,7 +43,7 @@ describe('Error Summary', () => {
     ['a conditionally revealed input', 'yes-input', '#test-conditional-reveal legend']
   ]
 
-  describe.each(inputTypes)('when linking to %s', async (_, inputId, legendOrLabelSelector) => {
+  describe.each(inputTypes)('when linking to %s', (_, inputId, legendOrLabelSelector) => {
     beforeAll(async () => {
       await page.goto(`${baseUrl}/examples/error-summary`, { waitUntil: 'load' })
       await page.click(`.govuk-error-summary a[href="#${inputId}"]`)