Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI2: Unify show_info variants on T2T1 #2739

Open
matejcik opened this issue Jan 12, 2023 · 1 comment
Open

UI2: Unify show_info variants on T2T1 #2739

matejcik opened this issue Jan 12, 2023 · 1 comment
Labels
code Code improvements

Comments

@matejcik
Copy link
Contributor

There are currently four functions: show_info, show_success, show_error, show_warning, that are on the Rust side only differentiated by icon & button style.

For API unification with T2B1 (which does not use icons and colors), it would be great if there was one function show_popup? show modal? that accepts a string or an enum specifying the overall "style". That way T2B1 code can accept them as dummy arguments, while T2T1 code can make use of the value.

@matejcik matejcik added the code Code improvements label Jan 12, 2023
@obrusvit
Copy link
Contributor

Referring #4322

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code Code improvements
Projects
Status: No status
Development

No branches or pull requests

2 participants