Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure translated strings fully fit on screen for SLIP39 reset flow. #4341

Open
obrusvit opened this issue Nov 12, 2024 · 0 comments
Open

Ensure translated strings fully fit on screen for SLIP39 reset flow. #4341

obrusvit opened this issue Nov 12, 2024 · 0 comments
Labels
bug Something isn't working as expected core Trezor Core firmware. Runs on Trezor Model T and T2B1. translations Put this label on a PR to run tests in all languages

Comments

@obrusvit
Copy link
Contributor

obrusvit commented Nov 12, 2024

Describe the bug
Some strings are not fully visible during reset flow.
It is manifested in click tests listed below where asserts of translated strings were removed not to block the GFL PR #3686

Firmware version and revision
2.8.4

Desktop/smartphone setup (please complete the following information):
emu

To Reproduce
Steps to reproduce the behavior:

  1. uncomment TR asserts in:
    • click_tests/test_reset_slip39_basic.py
    • click_tests/test_reset_slip39_advanced.py
    • click_tests/test_reset_bip39.py
  2. run click tests e.g. for T3B1, cs

Expected behavior
Translated strings overlapping should be collected and shortened by the agency.

Screenshots

Additional context

@obrusvit obrusvit added core Trezor Core firmware. Runs on Trezor Model T and T2B1. bug Something isn't working as expected translations Put this label on a PR to run tests in all languages labels Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working as expected core Trezor Core firmware. Runs on Trezor Model T and T2B1. translations Put this label on a PR to run tests in all languages
Projects
Status: No status
Development

No branches or pull requests

1 participant