You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
There have been a lot of discussions around confirm_blob, confirm_action, warnings and related code. Some of the more serious issues have been fixed, but it is time to take a step back and refactor this part of our code base once for all, especially since the upcoming FirmwareUI API will demand more consistency here.
Let's centralize all tasks below:
unify warning_hi_prio across models
T3B1: make warning_hi_prio cancelable
drop text_mono from confirm_blob
drop info from confirm_blob
drop hold from confirm_blob
confirm_blob_intro: is there a better way to do this?
rename ConfirmBlobParams.cancel to something else
look into menus that have just "cancel" as a menu item
PS: This will be an on-going effort, perhaps split into multiple unrelated PRs, but let's keep it concrete and actionable.
The text was updated successfully, but these errors were encountered:
There have been a lot of discussions around
confirm_blob
,confirm_action
, warnings and related code. Some of the more serious issues have been fixed, but it is time to take a step back and refactor this part of our code base once for all, especially since the upcomingFirmwareUI
API will demand more consistency here.Let's centralize all tasks below:
warning_hi_prio
across modelswarning_hi_prio
cancelabletext_mono
fromconfirm_blob
info
fromconfirm_blob
hold
fromconfirm_blob
confirm_blob_intro
: is there a better way to do this?ConfirmBlobParams.cancel
to something elsePS: This will be an on-going effort, perhaps split into multiple unrelated PRs, but let's keep it concrete and actionable.
The text was updated successfully, but these errors were encountered: