Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup confirm_blob & related code #4386

Open
2 of 8 tasks
ibz opened this issue Nov 26, 2024 · 0 comments · May be fixed by #4372
Open
2 of 8 tasks

Cleanup confirm_blob & related code #4386

ibz opened this issue Nov 26, 2024 · 0 comments · May be fixed by #4372
Assignees
Labels
code Code improvements

Comments

@ibz
Copy link
Contributor

ibz commented Nov 26, 2024

There have been a lot of discussions around confirm_blob, confirm_action, warnings and related code. Some of the more serious issues have been fixed, but it is time to take a step back and refactor this part of our code base once for all, especially since the upcoming FirmwareUI API will demand more consistency here.

Let's centralize all tasks below:

  • unify warning_hi_prio across models
  • T3B1: make warning_hi_prio cancelable
  • drop text_mono from confirm_blob
  • drop info from confirm_blob
  • drop hold from confirm_blob
  • confirm_blob_intro: is there a better way to do this?
  • rename ConfirmBlobParams.cancel to something else
  • look into menus that have just "cancel" as a menu item

PS: This will be an on-going effort, perhaps split into multiple unrelated PRs, but let's keep it concrete and actionable.

@ibz ibz added the code Code improvements label Nov 26, 2024
@ibz ibz self-assigned this Nov 26, 2024
@ibz ibz linked a pull request Nov 26, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code Code improvements
Projects
Status: No status
Development

Successfully merging a pull request may close this issue.

1 participant