Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kafka with KRaft #69

Draft
wants to merge 10 commits into
base: main
Choose a base branch
from
Draft

Kafka with KRaft #69

wants to merge 10 commits into from

Conversation

iblutrifork
Copy link
Contributor

@iblutrifork iblutrifork commented Apr 23, 2024

Add a docker compose for local development, which starts a Kafka instance running KRaft, instead of Zookeeper.

This PR uses the Kafka docker image compiled from https://github.com/trifork/cheetah-infrastructure-utils-kafka/pull/77.

This new docker compose runs a Kafka in KRaft mode in both controller and broker mode combined.
Controller mode is when Kafka acts as Zookeeper (runs the consensus algorithm).
Broker mode is when Kafka acts like a message queue (the way it always was).

Changes from the way we ran Kafka using Zookeeper:

Copy link

github-actions bot commented Apr 23, 2024

🦙 MegaLinter status: ⚠️ WARNING

Descriptor Linter Files Fixed Errors Elapsed time
✅ BASH shellcheck 5 0 0.24s
⚠️ BASH shfmt 5 1 0.03s
✅ COPYPASTE jscpd yes no 1.08s
✅ DOCKERFILE hadolint 1 0 0.09s
✅ JSON jsonlint 4 0 0.33s
⚠️ JSON prettier 4 1 2.03s
✅ JSON v8r 4 0 2.71s
✅ REPOSITORY git_diff yes no 0.01s
✅ REPOSITORY grype yes no 15.17s
✅ REPOSITORY trivy yes no 7.79s
✅ REPOSITORY trivy-sbom yes no 5.93s
✅ REPOSITORY trufflehog yes no 4.3s
⚠️ YAML prettier 19 1 1.94s
✅ YAML v8r 19 0 6.02s
⚠️ YAML yamllint 19 1 1.0s

See detailed report in MegaLinter reports

MegaLinter is graciously provided by OX Security

@cthtrifork
Copy link
Contributor

Great work. Did you verify it together with redpanda as well?

Also with OAuth2 please:
https://github.com/trifork/cheetah-development-infrastructure/blob/main/docker-compose/kafka.yaml#L106C10-L106C131

@iblutrifork
Copy link
Contributor Author

Great work. Did you verify it together with redpanda as well?

Also with OAuth2 please: https://github.com/trifork/cheetah-development-infrastructure/blob/main/docker-compose/kafka.yaml#L106C10-L106C131

Tested with both by creating a topic and writing a message to it through the redpanda UI

@iblutrifork iblutrifork marked this pull request as ready for review April 30, 2024 09:48
@iblutrifork iblutrifork marked this pull request as draft April 30, 2024 09:50
@iblutrifork iblutrifork marked this pull request as ready for review April 30, 2024 10:10
@cthtrifork cthtrifork marked this pull request as draft August 13, 2024 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants