Remove processEvents in PythonEngineWorker::doRun() #810
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the destructor of
trikPythonRunner
is called,mWorkerThread->quit()
is invoked. Thefinished
signal ofmWorkerThread
is connected topythonEngineWorker::deleteLater
. However, when attempting to free resources immediately after script execution (inPythonEngineWorker::doRun()
), calls toQCoreApplication::processEvents
reset theinterrupt
flag set bymWorkerThread->quit()
. As a result,QEventLoop::exec
calls blokingMsgWaitForMultipleObjectsEx
(viaQEventDispatcherWin32::processEvents
) with theINFINITE
flag (specifically forQEventLoop::WaitForMoreEvents
), which leads to waiting for aPostMessage
call that can be triggered byQEventLoop::wakeUp
,QAbstractEventDispatcher::interrupt
, or re-callingqthread->quit
. Calls toQCoreApplication::processEvents
withQEventLoop::WaitForMoreEvents
generate theQAbstractEventDispatcher::aboutToBlock
signal. This solution should not introduce regression because all current calls toQCoreApplication::processEvents
occur withQEventLoop::AllEvents
and will not be canceled.