fix(boa_engine): fix conversion from undefined to JSON

trilitech · Mar 6, 2024 · 78c8540 · 78c8540
1 parent 41b24d5
commit 78c8540
Showing 1 changed file with 3 additions and 5 deletions.
diff --git a/boa_engine/src/value/conversions/serde_json.rs b/boa_engine/src/value/conversions/serde_json.rs
@@ -108,14 +108,12 @@ impl JsValue {
     /// #
     /// # assert_eq!(json, back_to_json);
     /// ```
-    ///
-    /// # Panics
-    ///
-    /// Panics if the `JsValue` is `Undefined`.
     pub fn to_json(&self, context: &mut Context<'_>) -> JsResult<Value> {
         match self {
             Self::Null => Ok(Value::Null),
-            Self::Undefined => todo!("undefined to JSON"),
+            Self::Undefined => Err(JsNativeError::typ()
+                .with_message("cannot convert undefined to JSON")
+                .into()),
             &Self::Boolean(b) => Ok(b.into()),
             Self::String(string) => Ok(string.to_std_string_escaped().into()),
             &Self::Rational(rat) => Ok(rat.into()),