Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maximum one expert-mode warning per signing flow #284

Merged
merged 4 commits into from
Sep 13, 2024

Conversation

spalmer25
Copy link
Collaborator

fixes #282

Currently, when a batch operation contains multiple fields requiring expert mode, the ledger displays a warning screen before each of them.

This PR adds changes to display the expert mode warning screen only before the first field that requires it.

@spalmer25 spalmer25 self-assigned this Sep 12, 2024
@spalmer25 spalmer25 force-pushed the palmer@functori@expert-mode-warning-once branch from 88bef07 to 1b987ee Compare September 13, 2024 07:49
@spalmer25 spalmer25 force-pushed the palmer@functori@expert-mode-warning-once branch 2 times, most recently from 1b1ecbe to df24e42 Compare September 13, 2024 08:14
@spalmer25 spalmer25 marked this pull request as ready for review September 13, 2024 08:20
Copy link
Collaborator

@ajinkyaraj-23 ajinkyaraj-23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@spalmer25 spalmer25 force-pushed the palmer@functori@expert-mode-warning-once branch from df24e42 to 406b144 Compare September 13, 2024 09:36
@spalmer25 spalmer25 force-pushed the palmer@functori@expert-mode-warning-once branch from 406b144 to 3394286 Compare September 13, 2024 13:53
@spalmer25 spalmer25 merged commit f510cb5 into main Sep 13, 2024
138 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Maximum one expert-mode warning per signing flow
2 participants