tezos-encoding + derive: keep track of lifetime in NomReader #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emturner
reviewed
Nov 21, 2023
emturner
reviewed
Nov 21, 2023
emturner
reviewed
Nov 21, 2023
emturner
reviewed
Nov 21, 2023
emturner
reviewed
Nov 21, 2023
emturner
reviewed
Nov 21, 2023
emturner
reviewed
Nov 21, 2023
emturner
reviewed
Nov 21, 2023
tezos-encoding/src/nom.rs
Outdated
| deserialized: Option<T>, | ||
| } | ||
|
|
||
| impl<'a, T> NomReader<'a> for LazyCell<'a, T> |
There was a problem hiding this comment.
ideally would have a impl From<T> for LazyCell`?
and a BinWriter for LazyCell which internally would 'fail' the value if not present.
emturner
reviewed
Nov 21, 2023
|
Thanks for the PR! Overall a big fan of adding something like this. Pretty happy with the first commit - most comments focused on the second (perhaps could be split out into a second PR if needed) |
|
Thanks for the review. I agree to split this in two PRs. |
rafoo
force-pushed
the
rafoo@lifetime_in_nomreader
branch
2 times, most recently
from
6359e45
to
cc63f5f
Compare
|
I've removed the second commit. All remaining comments are now outdated if I am not mistaken. |
The `NomReader` trait is implicitly parameterized by the lifetime of the input byte slice. This commit makes the quantification on this explicit. This is needed to implement `NomReader` for structures which keep a reference to some slice of the input, for example to implement lazy deserialization.
rafoo
force-pushed
the
rafoo@lifetime_in_nomreader
branch
from
cc63f5f
to
6cb8c5e
Compare
emturner
approved these changes
Dec 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
NomReadertrait is implicitly parameterized by the lifetime of the input byte slice. This commit makes the quantification on this explicit. This is needed to implementNomReaderfor structures which keep a reference to some slice of the input, for example to implement lazy deserialization.