Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crypto: remove legacy base58 encoding for SecretKeyEd25519 #59

Merged
merged 1 commit into from
Dec 20, 2023

Conversation

emturner
Copy link
Collaborator

The previous base58 check encoding was incorrectly using the legacy format, where the encoded key was actually the concatenation of sk + pk.

fixes #45

@emturner emturner force-pushed the emturner@sked25519-b58 branch 2 times, most recently from f3e528f to c64a247 Compare December 19, 2023 13:21
@rafoo
Copy link

rafoo commented Dec 20, 2023

I'm not very familiar with this code but the fix looks reasonable to me and the test seems to address issue #45.

@emturner emturner force-pushed the emturner@sked25519-b58 branch 2 times, most recently from 71622d6 to d43ab60 Compare December 20, 2023 10:25
@rodibozman
Copy link

Took the diff from this MR applied it to v0.5, it fixes the issue pointed in #45. Thanks.

@emturner emturner merged commit 6752a5d into master Dec 20, 2023
7 checks passed
@emturner emturner deleted the emturner@sked25519-b58 branch December 20, 2023 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants