Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crypto: do not make inner hash public #62

Merged
merged 1 commit into from
Jan 2, 2024

Conversation

emturner
Copy link
Collaborator

This allows ToBase58Check to no longer return results, since we know the hashes will always be correctly constructed.

Copy link

@lierdakil lierdakil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

This allows ToBase58Check to no longer return results, since we
know the hashes will _always_ be correctly constructed.
@emturner emturner merged commit 2696597 into master Jan 2, 2024
7 checks passed
@emturner emturner deleted the emturner@to-base58-no-error branch January 2, 2024 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants