Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: build errors #1

Draft
wants to merge 1 commit into
base: v2.0
Choose a base branch
from
Draft

fix: build errors #1

wants to merge 1 commit into from

Conversation

dianasavvatina
Copy link
Collaborator

@dianasavvatina dianasavvatina commented Jul 25, 2024

Description

Fixed build errors:

There were many similar errors like this:

src/controllers/engine.ts:75:7 - error TS7053: Element implicitly has an 'any' type because expression of type 'string' can't be used to index type '{}'.
  No index signature with a parameter of type 'string' was found on type '{}'.

75       sessions[session.topic] = session;
         ~~~~~~~~~~~~~~~~~~~~~~~

Type of change

  • Chore (non-breaking change that addresses non-functional tasks, maintenance, or code quality improvements)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Draft PR (breaking/non-breaking change which needs more work for having a proper functionality [Mark this PR as ready to review only when completely ready])
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How has this been tested?

The number of failing tests has not increased.
The tests which were not executed previously as build has failed, are now passing.
Tested with

yarn build
yarn test

Checklist

  • I have performed a self-review of my own code
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@dianasavvatina dianasavvatina marked this pull request as draft July 26, 2024 08:53
@dianasavvatina dianasavvatina self-assigned this Jul 26, 2024
dianasavvatina pushed a commit that referenced this pull request Sep 10, 2024
merge wc monorepo to fork
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant