Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: Add service annotations support to Trino Gateway Chart #258

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Feat: Add service annotations support to Trino Gateway Chart #258

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5980200
feat: add service annotations support to Trino Gateway Chart
yashsinghalso Nov 20, 2024
1d8c9e8
Resolved last comments
yashsinghalso Nov 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions charts/gateway/templates/_helpers.tpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,3 +63,12 @@ Create the name of the service account to use
{{- default "default" .Values.serviceAccount.name }}
{{- end }}
{{- end }}

{{/*
Create annotations for service
*/}}
{{- define "trino-gateway.serviceAnnotations" -}}
nineinchnick marked this conversation as resolved.
Show resolved Hide resolved
{{- range $key, $value := .Values.service.annotations }}
{{ $key }}: {{ $value | quote }}
{{- end }}
{{- end }}
yashsinghalso marked this conversation as resolved.
Show resolved Hide resolved
2 changes: 2 additions & 0 deletions charts/gateway/templates/service.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@ metadata:
name: {{ include "trino-gateway.fullname" . }}
labels:
{{- include "trino-gateway.labels" . | nindent 4 }}
annotations:
{{- include "trino-gateway.serviceAnnotations" . | nindent 4 }}
spec:
type: {{ .Values.service.type }}
ports:
Expand Down
1 change: 1 addition & 0 deletions charts/gateway/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,7 @@ command:
service:
type: ClusterIP
port: 8080
annotations: {}

ingress:
enabled: false
Expand Down
Loading