Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement all TrinoParameterCollection methods #8

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

stelmukhov
Copy link
Member

Hi, can we implement all methods for the TrinoParameterCollection?

Copy link

cla-bot bot commented Jan 10, 2025

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Ihor Stelmukhov.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email [email protected]
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

Copy link
Contributor

@georgewfisher georgewfisher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great

@mosabua
Copy link
Member

mosabua commented Jan 13, 2025

@georgewfisher we have to wait with merge until @stelmukhov submitted a signed CLA and @martint processed it. Then we can trigger a revalidation here and merge.

@stelmukhov
Copy link
Member Author

Hi @mosabua @georgewfisher,
Could someone please trigger a revalidation? It should be good to go now.

@stelmukhov stelmukhov closed this Jan 28, 2025
@stelmukhov stelmukhov reopened this Jan 28, 2025
@mosabua
Copy link
Member

mosabua commented Jan 28, 2025

@cla-bot check

@cla-bot cla-bot bot added the cla-signed label Jan 28, 2025
Copy link

cla-bot bot commented Jan 28, 2025

The cla-bot has been summoned, and re-checked this pull request!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants