Support bytes #75
Support bytes #75
Conversation
|
Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla |
.vscode/launch.json
Outdated
| @@ -0,0 +1,18 @@ | |||
| { | |||
| // Use IntelliSense to learn about possible attributes. | |||
| case []byte: | ||
| return "", UnsupportedArgError{"[]byte"} | ||
| return "X'" + strings.ToUpper(hex.EncodeToString(x)) + "'", nil |
There was a problem hiding this comment.
This adds support for using []byte in query params, right? What about reading VARBINARY columns in query results?
Also, please update the README, there's a section there with a list of supported and not supported data types.
There was a problem hiding this comment.
reading VARBINARY columns in query results we need to implement sql.Scanner interface.
like
type TrinoVARBINARY []byte
func (h *TrinoVARBINARY) Scan(src any) (err error) {
switch s := src.(type) {
case string:
var bytes []byte
bytes, err = base64.StdEncoding.DecodeString(s)
if err == nil {
*h = bytes
}
default:
err = fmt.Errorf("unsupported type: %T", src)
}
return
}
There was a problem hiding this comment.
Would to like to try in this PR? I know I'm asking to extend the scope of work, so it's also ok to do this in a follow up PR
There was a problem hiding this comment.
I will do this in next PR. I hope to also support driver.Valuer interface
|
Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla |
README.md
Outdated
| @@ -196,6 +196,7 @@ When passing arguments to queries, the driver supports the following Go data typ | |||
| * integers | |||
| * `bool` | |||
| * `string` | |||
| * `bytes` | |||
README.md
Outdated
| @@ -255,7 +256,10 @@ will receive a `[]interface{}` slice, with values of the following types: | |||
| * `json.Number` for any numeric Trino types | |||
| * `[]interface{}` for Trino arrays | |||
| * `map[string]interface{}` for Trino maps | |||
| * `string` for other Trino types, as character, date, time, or timestamp | |||
| * `string` for other Trino types, as character, date, time, varbinary or timestamp | |||
There was a problem hiding this comment.
This section is about reading data from Trino. We discussed this in another comment that support for []byte will be added in a separate PR, so remove this for now
|
Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla |
|
@cla-bot check |
|
Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla |
|
The cla-bot has been summoned, and re-checked this pull request! |
translate bytes to 'VARBINARY' in trino so we can filter column which type is ‘VARBINARY’ by bytes