Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make generate-service-descriptor thread-safe again #25

Merged
merged 1 commit into from
May 29, 2024

Conversation

wendigo
Copy link
Contributor

@wendigo wendigo commented May 29, 2024

SimpleDateFormat is not thread-safe which causes plugin to fail with the cryptic errors like For input string: "E.404E2"

@cla-bot cla-bot bot added the cla-signed label May 29, 2024
@wendigo wendigo requested a review from findepi May 29, 2024 08:58
@wendigo wendigo force-pushed the serafin/make-thread-safe-again branch 2 times, most recently from 3125102 to 4258405 Compare May 29, 2024 10:15
@wendigo
Copy link
Contributor Author

wendigo commented May 29, 2024

This is now on-par with the maven-assembly plugin outputTimestamp handling

@wendigo
Copy link
Contributor Author

wendigo commented May 29, 2024

(base) ➜  target git:(master) ✗ ls -la io/trino/plugin/mysql
total 248
drwxr-xr-x  15 mateuszgajewski  staff    480 May 16 00:57 .
drwxr-xr-x   3 mateuszgajewski  staff     96 May 16 00:57 ..
-rw-r--r--   1 mateuszgajewski  staff    494 May 16 00:57 ImplementAvgBigint.class
-rw-r--r--   1 mateuszgajewski  staff   1430 May 16 00:57 MySqlClient$1.class
-rw-r--r--   1 mateuszgajewski  staff   1474 May 16 00:57 MySqlClient$2.class
-rw-r--r--   1 mateuszgajewski  staff   1437 May 16 00:57 MySqlClient$3.class
-rw-r--r--   1 mateuszgajewski  staff    872 May 16 00:57 MySqlClient$4.class
-rw-r--r--   1 mateuszgajewski  staff   5111 May 16 00:57 MySqlClient$ColumnHistogram.class
-rw-r--r--   1 mateuszgajewski  staff   1749 May 16 00:57 MySqlClient$ColumnIndexStatistics.class
-rw-r--r--   1 mateuszgajewski  staff   7264 May 16 00:57 MySqlClient$StatisticsDao.class
-rw-r--r--   1 mateuszgajewski  staff  64410 May 16 00:57 MySqlClient.class
-rw-r--r--   1 mateuszgajewski  staff   5391 May 16 00:57 MySqlClientModule.class
-rw-r--r--   1 mateuszgajewski  staff   2201 May 16 00:57 MySqlConfig.class
-rw-r--r--   1 mateuszgajewski  staff   1561 May 16 00:57 MySqlJdbcConfig.class
-rw-r--r--   1 mateuszgajewski  staff    446 May 16 00:57 MySqlPlugin.class
(base) ➜  target git:(master) ✗ ls -la META-INF/services
total 8
drwxr-xr-x  3 mateuszgajewski  staff   96 May 29 12:12 .
drwxr-xr-x  5 mateuszgajewski  staff  160 May 29 12:15 ..
-rw-r--r--  1 mateuszgajewski  staff   34 May 16 00:57 io.trino.spi.Plugin

@wendigo wendigo force-pushed the serafin/make-thread-safe-again branch from 4258405 to 5e37942 Compare May 29, 2024 10:17
SimpleDateFormat is not thread-safe which causes plugin to fail with the cryptic errors
like `For input string: "E.404E2"`
@wendigo wendigo force-pushed the serafin/make-thread-safe-again branch from 5e37942 to e031952 Compare May 29, 2024 10:20
@wendigo wendigo merged commit 6bd5b20 into master May 29, 2024
2 checks passed
@wendigo wendigo deleted the serafin/make-thread-safe-again branch May 29, 2024 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants