Remove redundant constructors from Extract

trinodb · Sep 15, 2024 · 57ec0d2 · 57ec0d2
1 parent 17d20bf
commit 57ec0d2
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 12 deletions.
diff --git a/core/trino-parser/src/main/java/io/trino/sql/tree/ExpressionTreeRewriter.java b/core/trino-parser/src/main/java/io/trino/sql/tree/ExpressionTreeRewriter.java
@@ -833,7 +833,7 @@ protected Expression visitExtract(Extract node, Context<C> context)
             Expression expression = rewrite(node.getExpression(), context.get());
 
             if (node.getExpression() != expression) {
-                return new Extract(expression, node.getField());
+                return new Extract(node.getLocation().orElseThrow(), expression, node.getField());
             }
 
             return node;

diff --git a/core/trino-parser/src/main/java/io/trino/sql/tree/Extract.java b/core/trino-parser/src/main/java/io/trino/sql/tree/Extract.java
@@ -50,19 +50,9 @@ public enum Field
         TIMEZONE_HOUR
     }
 
-    public Extract(Expression expression, Field field)
-    {
-        this(Optional.empty(), expression, field);
-    }
-
     public Extract(NodeLocation location, Expression expression, Field field)
     {
-        this(Optional.of(location), expression, field);
-    }
-
-    private Extract(Optional<NodeLocation> location, Expression expression, Field field)
-    {
-        super(location);
+        super(Optional.of(location));
         requireNonNull(expression, "expression is null");
         requireNonNull(field, "field is null");