Remove redundant constructors from DropColumn

trinodb · Sep 15, 2024 · febbfe1 · febbfe1
1 parent f0f3462
commit febbfe1
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 12 deletions.
diff --git a/core/trino-main/src/test/java/io/trino/execution/TestDropColumnTask.java b/core/trino-main/src/test/java/io/trino/execution/TestDropColumnTask.java
@@ -25,6 +25,7 @@
 import io.trino.spi.type.RowType;
 import io.trino.spi.type.RowType.Field;
 import io.trino.sql.tree.DropColumn;
+import io.trino.sql.tree.NodeLocation;
 import io.trino.sql.tree.QualifiedName;
 import org.junit.jupiter.api.Test;
 
@@ -167,7 +168,7 @@ public void testDropColumnOnMaterializedView()
     private ListenableFuture<Void> executeDropColumn(QualifiedName table, QualifiedName column, boolean tableExists, boolean columnExists)
     {
         return new DropColumnTask(plannerContext.getMetadata(), new AllowAllAccessControl())
-                .execute(new DropColumn(table, column, tableExists, columnExists), queryStateMachine, ImmutableList.of(), WarningCollector.NOOP);
+                .execute(new DropColumn(new NodeLocation(1, 1), table, column, tableExists, columnExists), queryStateMachine, ImmutableList.of(), WarningCollector.NOOP);
     }
 
     private static ConnectorTableMetadata simpleTable(QualifiedObjectName tableName)

diff --git a/core/trino-parser/src/main/java/io/trino/sql/tree/DropColumn.java b/core/trino-parser/src/main/java/io/trino/sql/tree/DropColumn.java
@@ -30,19 +30,9 @@ public class DropColumn
     private final boolean tableExists;
     private final boolean columnExists;
 
-    public DropColumn(QualifiedName table, QualifiedName field, boolean tableExists, boolean columnExists)
-    {
-        this(Optional.empty(), table, field, tableExists, columnExists);
-    }
-
     public DropColumn(NodeLocation location, QualifiedName table, QualifiedName field, boolean tableExists, boolean columnExists)
     {
-        this(Optional.of(location), table, field, tableExists, columnExists);
-    }
-
-    private DropColumn(Optional<NodeLocation> location, QualifiedName table, QualifiedName field, boolean tableExists, boolean columnExists)
-    {
-        super(location);
+        super(Optional.of(location));
         this.table = requireNonNull(table, "table is null");
         this.field = requireNonNull(field, "field is null");
         this.tableExists = tableExists;