Use correct abbreviations for data quantities

[metadaddy]

Description

The Trino CLI currently reports data size incorrectly, using the legacy, 1,024-based, values for K, M, G etc rather than the modern 1,000-based values.

Is this change a fix, improvement, new feature, refactoring, or other?

Fix

Is this a change to the core query engine, a connector, client library, or the SPI interfaces? (be specific)

CLI

How would you describe this change to a non-technical end user or system administrator?

This change corrects the display of data sizes in the CLI to use 1,000-based units.

Related issues, pull requests, and links

• Fixes Trino CLI reports data with wrong units #13054

Documentation

( ) No documentation is needed.
( ) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.

Release notes

( ) No release notes entries required.
( ) Release notes entries required with the following suggested text:

[cla-bot]

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please submit the signed CLA to [email protected]. For more information, see https://github.com/trinodb/cla.

[dain]

If you search the issue and PR history this has been discussed several time before. At this point we can not change this behavior.

[metadaddy]

Hi @dain - I spent a good 30 mins looking, but I couldn't see any previous issues or PRs on this topic. In any case, it's your project.

Is there any value in the tests I wrote for the CLI FormatUtils class? I'd be happy to modify the relevant test to fit the current behavior and submit them in a separate PR.

[dain]

It seems that @martint may be ok with this for the CLI

[metadaddy]

Cool - I'll do the CLA thing.

[findepi]

Fixing the CLI is correct in isolation but will introduce inconsistency with Trino built-in function parse_data_size (https://trino.io/docs/current/functions/conversion.html#parse_data_size) which we're not planning on changing (per #11160 (review)).

Wonder how we proceed here.
cc @nineinchnick @electrum

[electrum]

I think it would be better to keep the base-2 units and simply add the i to the unit designation. This preserves the existing behavior and compatibility with base-2 units used everywhere else.

[metadaddy]

Oops - I submitted this PR from my master branch, then I needed to sync back for another change. I'll submit another PR with a different branch and reference this one.

[metadaddy]

Replaced by #14859