Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change client_info column_type to MEDIUMTEXT #23427

Merged
merged 1 commit into from
Nov 20, 2024
Merged

change client_info column_type to MEDIUMTEXT #23427

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...rino-mysql-event-listener/src/main/java/io/trino/plugin/eventlistener/mysql/QueryDao.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ public interface QueryDao
" trace_token VARCHAR(255) NULL,\n" +
" remote_client_address VARCHAR(255) NULL,\n" +
" user_agent VARCHAR(255) NULL,\n" +
" client_info VARCHAR(255) NULL,\n" +
" client_info MEDIUMTEXT NULL,\n" +
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But how would perform migration - In case of older tables which has this column as a VARCHAR(255)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think for both this and the DB resource groups we rely on users manually managing the schema. There are no migrations.

Introducing migrations is a bigger task here and with how less often the changes happen here I think it's fine to skip for now.

" client_tags_json MEDIUMTEXT NOT NULL,\n" +
" source VARCHAR(255) NULL,\n" +
" catalog VARCHAR(255) NULL,\n" +
Expand Down