Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Method name update, borderEmpty -> border #4683

Closed
wants to merge 1 commit into from
Closed

Method name update, borderEmpty -> border #4683

wants to merge 1 commit into from

Conversation

DanVanAtta
Copy link
Member

Overview

The 'border' method now becomes an overload, bit more obvious that it is
a simplified version of 'border(BorderBuilder)'

Functional Changes

none

The 'border' method now becomes an overload, bit more obvious that it is
a simplified version of 'border(BorderBuilder)'
@codecov-io
Copy link

Codecov Report

Merging #4683 into master will decrease coverage by <.01%.
The diff coverage is 6.25%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #4683      +/-   ##
============================================
- Coverage     23.21%   23.21%   -0.01%     
+ Complexity     6212     6210       -2     
============================================
  Files           873      873              
  Lines         70489    70488       -1     
  Branches      11240    11240              
============================================
- Hits          16367    16364       -3     
  Misses        52085    52085              
- Partials       2037     2039       +2
Impacted Files Coverage Δ Complexity Δ
...ine/framework/map/download/DownloadMapsWindow.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...c/main/java/games/strategy/debug/ErrorMessage.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...ategy/debug/error/reporting/ErrorReportWindow.java 0% <0%> (ø) 0 <0> (ø) ⬇️
.../error/reporting/ConfirmationDialogController.java 0% <0%> (ø) 0 <0> (ø) ⬇️
.../strategy/debug/error/reporting/PreviewWindow.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...trategy/engine/lobby/client/ui/TimespanDialog.java 27.58% <0%> (ø) 3 <0> (ø) ⬇️
...ne/framework/startup/ui/panels/main/MainPanel.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...ames/strategy/triplea/settings/SettingsWindow.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...games/strategy/triplea/ui/FindTerritoryDialog.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...src/main/java/org/triplea/swing/JPanelBuilder.java 45.03% <100%> (+0.34%) 19 <1> (ø) ⬇️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f33315...ddf79db. Read the comment docs.

@DanVanAtta
Copy link
Member Author

Subsumed and merged into #4687

@DanVanAtta DanVanAtta closed this Feb 16, 2019
@DanVanAtta DanVanAtta deleted the border-empty-name-change branch February 16, 2019 02:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants