Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wire up client to send errors to http server / Change 'shows details' button to 'report to TripleA' #4687

Merged
merged 5 commits into from
Feb 22, 2019
Merged

Wire up client to send errors to http server / Change 'shows details' button to 'report to TripleA' #4687

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
124bec3
Method name update, borderEmpty -> border
DanVanAtta Feb 15, 2019
8ff09bf
Add 'toolTip' property to JTextAreaBuilder
DanVanAtta Feb 15, 2019
3c82ca5
Wire up client to send errors to http server
DanVanAtta Feb 16, 2019
36fe92f
Simplify: Use Collectors.joining over String.join
DanVanAtta Feb 17, 2019
ed10bfa
Change: Single space the stack trace in error report instead of doubl…
DanVanAtta Feb 17, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions ...re/src/main/java/games/strategy/debug/error/reporting/StackTraceErrorReportFormatter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
import java.util.Optional;
import java.util.function.BiFunction;
import java.util.logging.LogRecord;
import java.util.stream.Collectors;

import javax.annotation.Nullable;

Expand Down Expand Up @@ -94,14 +95,14 @@ private static String throwableToString(final Throwable e) {
+ Optional.ofNullable(e.getStackTrace())
.map(
trace -> "## Stack Trace\n"
+ String.join("\n", stackTraceToString(trace))
+ stackTraceToString(trace)
+ "\n\n")
.orElse("");
}

private static String[] stackTraceToString(final StackTraceElement[] stackTrace) {
private static String stackTraceToString(final StackTraceElement[] stackTrace) {
return Arrays.stream(stackTrace)
.map(StackTraceElement::toString)
.toArray(String[]::new);
.collect(Collectors.joining("\n\n"));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm curious where the additional newline comes from.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good eye, fixed: ed10bfa

}
}