Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix reset error in TRIXO form #1154

Merged
merged 1 commit into from
Jan 24, 2024
Merged

Fix reset error in TRIXO form #1154

merged 1 commit into from
Jan 24, 2024

Conversation

daniellemaxwell
Copy link
Collaborator

@daniellemaxwell daniellemaxwell commented Jan 24, 2024 •
edited
Loading

Scope of changes

Fix error in TRIXO form so that the page will reload and remove data after users confirm that they'd like to reset the form.

Type of change

  • bug fix
  • new feature
  • documentation
  • other (describe)

Acceptance criteria

https://www.awesomescreenshot.com/video/24336690?key=b694f17e7dc16e7c8e4e344e3d7ea8fe

Author checklist

  • I have manually tested the change and/or added automation in the form of unit tests or integration tests
  • I have updated the dependencies list
  • I have recompiled and included new protocol buffers to reflect changes I made
  • I have added new test fixtures as needed to support added tests
  • Check this box if a reviewer can merge this pull request after approval (leave it unchecked if you want to do it yourself)
  • I have moved the associated Shortcut story to "Ready for Review"

Reviewer(s) checklist

  • Any new user-facing content that has been added for this PR has been QA'ed to ensure correct grammar, spelling, and understandability.

@daniellemaxwell daniellemaxwell marked this pull request as ready for review January 24, 2024 18:49
bbengfort
bbengfort approved these changes Jan 24, 2024
View reviewed changes
Copy link
Collaborator

@bbengfort bbengfort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@bbengfort bbengfort merged commit e465015 into main Jan 24, 2024
15 checks passed
@bbengfort bbengfort deleted the sc-23524 branch January 24, 2024 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bbengfort bbengfort bbengfort approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@daniellemaxwell @bbengfort