Resend Password Utility #1169
Merged
Resend Password Utility #1169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbengfort
commented
May 22, 2024
There was a problem hiding this comment.
This file can be ignored for your review. This is just the resend password utility that I wrote to get the PKCS12 password back to Nikolay.
bbengfort
commented
May 22, 2024
There was a problem hiding this comment.
This file can also be ignored, it is generated using go generate from the html and txt email template files.
bbengfort
commented
May 22, 2024
| @@ -47,27 +47,32 @@ type VerifyContactData struct { | |||
| // VerifyContactURL composes the link to verify the contact from the context. If the | |||
| // link is not able to be composed, the function returns an empty string and logs an | |||
| // error because without the link the email is fairly useless. | |||
| func (d VerifyContactData) VerifyContactURL() string { | |||
| func (d VerifyContactData) VerifyContactURL() *url.URL { | |||
There was a problem hiding this comment.
Changing this to a URL will fix future problems with URLs and ensure proper encoding … we should use url.URL in all of our templates instead of string.
bbengfort
commented
May 22, 2024
Comment on lines
+73
to
+75
| func (d VerifyContactData) VerifyContactURLUnencoded() template.HTML { | ||
| url := d.VerifyContactURL() | ||
| return template.HTML(url.String()) |
There was a problem hiding this comment.
this is the equivalent of safeHTML in hugo -- it keeps the & as & instead of & -- I'm using it only for text not for a href based on my reading of the HTML5 spec.
daniellemaxwell
approved these changes
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scope of changes
Adds a
reissuerhelper command to resend the PKCS12 password of the last certificate request (if the user lost it or it expired and so long as the password is still in Google Secret manager).Also fixes the wording of the email to be less confusing and the & bug referred to us by Bitonic.
Fixes SC-24910 and SC-25491
Type of change
Acceptance criteria
Please pay special attention to wording and HTML in the email templates.
Author checklist
Reviewer(s) checklist