Update banner and compliance page copy #1172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daniellemaxwell
commented
Jun 25, 2024
| @@ -14,8 +14,8 @@ const LandingBanner = () => { | |||
| <AlertIcon/> | |||
| <AlertDescription fontWeight={'semibold'}> | |||
| <Link href="https://calendar.app.google/FBg7GTmgDfeMbUMT9" isExternal> | |||
| <Trans id="Schedule a demo to learn about TRISA's open source self-hosted solution for cost-effective Travel Rule compliance."> | |||
There was a problem hiding this comment.
The id isn't required to extract the text to a .po file for translation, so it has been remove here and in the other component file.
daniellemaxwell
commented
Jun 25, 2024
| </Line> | ||
| <Line title={t`3rd Party Travel Rule Providers`}> | ||
| <UnorderedList color={'#1F4CED'}> | ||
| <Box pt={4}> |
There was a problem hiding this comment.
This differs from the Figma design as the table component extended outside the container even with a max width set. I attempted a grid with 3 columns, but then ran into an issue with some of the text inside a grid item aligning in the center although a text align style had not been applied.
daniellemaxwell
commented
Jun 25, 2024
| const originalRequest = error?.config; | ||
| originalRequest._retry = originalRequest?._retry || 0; | ||
| // | ||
| if (originalRequest) { |
There was a problem hiding this comment.
This will hopefully resolve an undefined error since adding optional chaining (?.) didn't work.
pdamodaran
approved these changes
Jun 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scope of changes
Integrate & Complypage.Note:
.pofiles and a snapshot have also been updated. These do not require a review as they are automatically generated.Comply page Figma design
Type of change
Acceptance criteria
https://www.awesomescreenshot.com/video/28968107?key=40bfeefbc59f8d9919841e6957404e18
Author checklist
Reviewer(s) checklist