Rename methods on SyntaxSetBuilder #195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While we're breaking API anyway, I think this makes them a bit clearer: * `add_syntax` -> `add` * `load_syntaxes` -> `load_from_folder` * `load_plain_text_syntax` -> `add_plain_text_syntax`
robinst
commented
Aug 2, 2018
| @@ -292,22 +295,22 @@ impl SyntaxSetBuilder { | |||
| } | |||
|
|
|||
| /// Add a syntax to the set. | |||
| pub fn add_syntax(&mut self, syntax: SyntaxDefinition) { | |||
| pub fn add(&mut self, syntax: SyntaxDefinition) { | |||
| self.syntaxes.push(syntax); | |||
| } | |||
|
|
|||
| /// Rarely useful method that loads in a syntax with no highlighting rules for plain text. | |||
| /// Exists mainly for adding the plain text syntax to syntax set dumps, because for some | |||
| /// reason the default Sublime plain text syntax is still in `.tmLanguage` format. | |||
| #[cfg(feature = "yaml-load")] | |||
There was a problem hiding this comment.
I noticed that this needs YAML, but we could change it to instead just create the structs directly. Any thoughts?
There was a problem hiding this comment.
Sure if you want to do the translation, submit a separate PR and I'll approve.
|
I have a breaking change I may want to make to the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While we're breaking API anyway, I think this makes them a bit clearer:
add_syntax->addload_syntaxes->load_from_folderload_plain_text_syntax->add_plain_text_syntax