tests/public_api: Omit blanket impls #501
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CI is currently failing because
Fix this by removing blanket implementations from the public API surface check. This should reduce maintenance because of lack of a Cargo.lock, at the cost if not fully checking the public API.
The "right" solution is might be to begin to version a Cargo.lock, so that CI is reproducible, but that seems more invasive than relaxing the public API check, so let's take the non-intrusive route and see how it plays out long term.