Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests/public_api: Omit blanket impls #501

Merged
merged 1 commit into from
Nov 28, 2023

Conversation

Enselic
Copy link
Collaborator

@Enselic Enselic commented Nov 28, 2023

CI is currently failing because

  • we are a library without a versioned Cargo.lock,
  • the blessed public API was made at a time when dependencies blanket implementations looked different.

Fix this by removing blanket implementations from the public API surface check. This should reduce maintenance because of lack of a Cargo.lock, at the cost if not fully checking the public API.

The "right" solution is might be to begin to version a Cargo.lock, so that CI is reproducible, but that seems more invasive than relaxing the public API check, so let's take the non-intrusive route and see how it plays out long term.

@Enselic Enselic merged commit 3f64679 into trishume:master Nov 28, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant