Fix #308 by escaping CSS class names #539
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keith-hall
approved these changes
May 2, 2024
|
I don't remember why the build failed now and the logs got deleted from being too old, it would be nice to get this to pass CI and merged... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is a fix for the issue #308 .
It modifies
css_for_theme_with_class_style()to automatically escape special characters in CSS class names according to the CSS specification.For example,
.123is replaced by.\31 23, and.c++is replaced by.c\2b \2b.Class names are escaped using the added function
escape_css_identifier().This PR also adds two tests: one to check the result of
escape_css_identifier(), and one to check if the generated CSS for theSolarized (dark)theme is properly escaped.If you have any suggestion or question, please don't hesitate to let me know.
Many thanks