Create an aggregate check-triton-unit target
#5150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterbell10
reviewed
Nov 15, 2024
CMakeLists.txt
Outdated
| @@ -312,4 +315,10 @@ add_subdirectory(test) | |||
|
|
|||
| if(TRITON_BUILD_UT) | |||
| add_subdirectory(unittest) | |||
| # This target runs all the unit tests. | |||
| add_custom_target(check-triton-unit | |||
There was a problem hiding this comment.
Some bikeshedding, how about run-TritonUnitTests?
There was a problem hiding this comment.
I chose this name because it lines up with check-triton-lit-tests, although by that logic, I should have named it check-triton-unit-tests :P
There was a problem hiding this comment.
Ah didn't know that existed haha. unit-tests does sound better though
There was a problem hiding this comment.
@peterbell10 I changed it to check-triton-unit-tests. PTAL :)
This adds a CMake target `check-triton-unit` that builds an runs all Triton unittests written in gtest. This makes it more conveninent to rebuild and run all unittests at once with finer granularity (instead of `ninja; ctest`).
Mogball
force-pushed
the
mogball/unittests
branch
from
f7f6168
to
9824d4d
Compare
peterbell10
approved these changes
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a CMake target
check-triton-unitthat builds an runs all Triton unittests written in gtest. This makes it more conveninent to rebuild and run all unittests at once with finer granularity (instead ofninja; ctest).